Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crashtracker] Refactor receiver code into seperate files. #818

Merged
merged 3 commits into from
Jan 14, 2025
Merged

[crashtracker] Refactor receiver code into seperate files. #818

merged 3 commits into from
Jan 14, 2025
+244 −215

Conversation

danielsn
Copy link
Contributor

What does this PR do?

Splits the code into cleaner files.

Motivation

I want to support the new RFC5 format, and this separates out the code that will need to change.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@danielsn danielsn requested a review from a team as a code owner January 10, 2025 20:13
@pr-commenter
Copy link

pr-commenter bot commented Jan 10, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-01-14 02:53:37

Comparing candidate commit c679a81 in PR branch dsn/crashtracker-split-receiver with baseline commit 5fd43ab in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c679a81 1736822582 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 36.643µs 37.305µs ± 1.050µs 36.830µs ± 0.093µs 36.958µs 39.557µs 39.623µs 40.176µs 9.09% 1.681 0.905 2.81% 0.074µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.159µs; 37.450µs] or [-0.390%; +0.390%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c679a81 1736822582 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 76.877µs 77.056µs ± 0.166µs 77.029µs ± 0.050µs 77.080µs 77.244µs 77.431µs 78.877µs 2.40% 7.083 71.874 0.21% 0.012µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [77.033µs; 77.079µs] or [-0.030%; +0.030%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c679a81 1736822582 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.456µs 28.154µs ± 14.719µs 18.922µs ± 0.399µs 37.505µs 48.037µs 56.612µs 152.779µs 707.41% 3.834 26.570 52.15% 1.041µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [26.114µs; 30.194µs] or [-7.246%; +7.246%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c679a81 1736822582 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 299.277µs 302.863µs ± 1.350µs 302.816µs ± 0.959µs 303.799µs 305.176µs 306.028µs 306.662µs 1.27% 0.123 -0.118 0.44% 0.095µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3260915.250op/s 3301883.953op/s ± 14712.900op/s 3302338.240op/s ± 10459.342op/s 3312552.790op/s 3324365.624op/s 3335442.534op/s 3341384.833op/s 1.18% -0.098 -0.124 0.44% 1040.359op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 27.105µs 27.286µs ± 0.071µs 27.288µs ± 0.053µs 27.341µs 27.393µs 27.438µs 27.483µs 0.72% -0.135 -0.455 0.26% 0.005µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 36385953.082op/s 36648464.659op/s ± 95692.308op/s 36646439.333op/s ± 70739.914op/s 36712712.308op/s 36807207.572op/s 36857152.824op/s 36893600.963op/s 0.67% 0.147 -0.455 0.26% 6766.468op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 15.889µs 16.091µs ± 0.170µs 16.000µs ± 0.063µs 16.304µs 16.370µs 16.410µs 16.429µs 2.68% 0.694 -1.257 1.06% 0.012µs 1 200
normalization/normalize_name/normalize_name/good throughput 60868354.130op/s 62152741.598op/s ± 653617.127op/s 62500430.677op/s ± 246669.276op/s 62647909.736op/s 62810467.697op/s 62895448.525op/s 62934978.034op/s 0.70% -0.686 -1.266 1.05% 46217.710op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [302.676µs; 303.051µs] or [-0.062%; +0.062%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3299844.887op/s; 3303923.020op/s] or [-0.062%; +0.062%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [27.277µs; 27.296µs] or [-0.036%; +0.036%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [36635202.625op/s; 36661726.693op/s] or [-0.036%; +0.036%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.068µs; 16.115µs] or [-0.147%; +0.147%] None None None
normalization/normalize_name/normalize_name/good throughput [62062156.550op/s; 62243326.646op/s] or [-0.146%; +0.146%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c679a81 1736822582 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.327ms 6.345ms ± 0.010ms 6.344ms ± 0.005ms 6.349ms 6.357ms 6.399ms 6.412ms 1.08% 3.148 17.157 0.16% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.344ms; 6.346ms] or [-0.022%; +0.022%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c679a81 1736822582 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 57.820ms 58.247ms ± 0.264ms 58.201ms ± 0.168ms 58.406ms 58.717ms 59.033ms 59.327ms 1.94% 1.092 1.738 0.45% 0.019ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [58.210ms; 58.283ms] or [-0.063%; +0.063%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c679a81 1736822582 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 296.358ns 308.207ns ± 12.927ns 301.078ns ± 3.578ns 314.904ns 338.901ns 343.649ns 346.236ns 15.00% 1.292 0.741 4.18% 0.914ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [306.416ns; 309.999ns] or [-0.581%; +0.581%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c679a81 1736822582 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 543.972µs 545.897µs ± 1.223µs 545.543µs ± 0.499µs 546.293µs 548.068µs 550.561µs 552.287µs 1.24% 1.981 5.374 0.22% 0.086µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1810651.770op/s 1831856.111op/s ± 4084.699op/s 1833035.555op/s ± 1675.070op/s 1834457.891op/s 1836273.399op/s 1837109.879op/s 1838330.125op/s 0.29% -1.958 5.240 0.22% 288.832op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 475.031µs 476.066µs ± 0.744µs 475.969µs ± 0.188µs 476.210µs 476.607µs 477.491µs 485.379µs 1.98% 9.921 120.928 0.16% 0.053µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2060244.141op/s 2100552.130op/s ± 3235.071op/s 2100978.326op/s ± 830.553op/s 2101656.459op/s 2102968.848op/s 2103377.227op/s 2105125.771op/s 0.20% -9.807 118.989 0.15% 228.754op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 194.553µs 195.194µs ± 0.835µs 195.106µs ± 0.183µs 195.278µs 195.511µs 199.686µs 203.301µs 4.20% 7.558 62.809 0.43% 0.059µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 4918803.498op/s 5123189.567op/s ± 21226.451op/s 5125415.892op/s ± 4791.500op/s 5130263.292op/s 5136001.176op/s 5138602.770op/s 5139978.523op/s 0.28% -7.460 61.441 0.41% 1500.937op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 47.157µs 47.637µs ± 0.175µs 47.632µs ± 0.132µs 47.770µs 47.911µs 47.969µs 48.089µs 0.96% -0.101 -0.450 0.37% 0.012µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 20794658.137op/s 20992362.544op/s ± 77233.761op/s 20994134.194op/s ± 58120.705op/s 21049456.292op/s 21117017.614op/s 21166631.296op/s 21205646.255op/s 1.01% 0.118 -0.439 0.37% 5461.252op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.761µs 50.133µs ± 0.165µs 50.150µs ± 0.097µs 50.229µs 50.329µs 50.402µs 51.335µs 2.36% 1.617 12.661 0.33% 0.012µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19479994.161op/s 19947166.744op/s ± 65198.461op/s 19940254.306op/s ± 38473.108op/s 19990866.565op/s 20043922.149op/s 20073747.639op/s 20095892.872op/s 0.78% -1.502 11.698 0.33% 4610.227op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [545.728µs; 546.067µs] or [-0.031%; +0.031%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1831290.011op/s; 1832422.211op/s] or [-0.031%; +0.031%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [475.963µs; 476.170µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2100103.781op/s; 2101000.480op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [195.079µs; 195.310µs] or [-0.059%; +0.059%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5120247.785op/s; 5126131.349op/s] or [-0.057%; +0.057%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [47.613µs; 47.661µs] or [-0.051%; +0.051%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [20981658.688op/s; 21003066.401op/s] or [-0.051%; +0.051%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [50.110µs; 50.156µs] or [-0.046%; +0.046%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [19938130.865op/s; 19956202.624op/s] or [-0.045%; +0.045%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c679a81 1736822582 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.419µs 3.294µs ± 1.479µs 3.092µs ± 0.027µs 3.120µs 3.741µs 14.427µs 15.399µs 398.06% 7.471 56.401 44.79% 0.105µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.089µs; 3.499µs] or [-6.223%; +6.223%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c679a81 1736822582 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.733µs 2.763µs ± 0.023µs 2.756µs ± 0.005µs 2.762µs 2.833µs 2.836µs 2.838µs 2.97% 2.074 3.608 0.85% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.760µs; 2.767µs] or [-0.118%; +0.118%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c679a81 1736822582 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 137.733µs 138.566µs ± 0.630µs 138.488µs ± 0.138µs 138.663µs 138.981µs 139.339µs 146.623µs 5.87% 10.595 132.375 0.45% 0.045µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [138.479µs; 138.653µs] or [-0.063%; +0.063%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c679a81 1736822582 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.269µs 4.291µs ± 0.005µs 4.290µs ± 0.001µs 4.292µs 4.295µs 4.301µs 4.343µs 1.22% 5.896 60.754 0.12% 0.000µs 1 200
credit_card/is_card_number/ throughput 230260974.291op/s 233053050.987op/s ± 271161.374op/s 233075748.468op/s ± 66571.366op/s 233133110.730op/s 233307772.237op/s 233409122.846op/s 234249109.004op/s 0.50% -5.798 59.685 0.12% 19174.005op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 92.340µs 93.546µs ± 0.510µs 93.525µs ± 0.256µs 93.792µs 94.157µs 94.468µs 98.211µs 5.01% 3.716 33.451 0.54% 0.036µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10182188.858op/s 10690246.350op/s ± 57163.830op/s 10692360.856op/s ± 29266.751op/s 10719905.016op/s 10770712.179op/s 10794286.142op/s 10829557.242op/s 1.28% -3.378 29.672 0.53% 4042.093op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 87.272µs 87.993µs ± 0.373µs 87.989µs ± 0.148µs 88.104µs 88.327µs 88.457µs 92.308µs 4.91% 7.717 87.812 0.42% 0.026µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 10833337.372op/s 11364741.454op/s ± 46684.424op/s 11365002.046op/s ± 19043.413op/s 11386063.174op/s 11413364.708op/s 11436171.180op/s 11458417.303op/s 0.82% -7.339 82.189 0.41% 3301.087op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.273µs 4.291µs ± 0.006µs 4.290µs ± 0.001µs 4.292µs 4.295µs 4.314µs 4.347µs 1.32% 5.756 52.846 0.13% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 230037147.397op/s 233065846.813op/s ± 304220.335op/s 233080747.530op/s ± 78366.945op/s 233149060.472op/s 233405864.381op/s 233480139.288op/s 234054873.668op/s 0.42% -5.671 51.807 0.13% 21511.626op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 85.051µs 85.530µs ± 0.202µs 85.514µs ± 0.134µs 85.661µs 85.886µs 86.010µs 86.180µs 0.78% 0.363 0.257 0.24% 0.014µs 1 200
credit_card/is_card_number/378282246310005 throughput 11603673.267op/s 11691816.960op/s ± 27576.714op/s 11693928.515op/s ± 18279.705op/s 11711221.402op/s 11734457.653op/s 11746499.794op/s 11757653.655op/s 0.54% -0.348 0.235 0.24% 1949.968op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 58.971µs 59.060µs ± 0.036µs 59.058µs ± 0.017µs 59.078µs 59.104µs 59.140µs 59.302µs 0.41% 1.376 10.062 0.06% 0.003µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16862715.574op/s 16932043.506op/s ± 10349.125op/s 16932408.366op/s ± 4953.513op/s 16936339.686op/s 16951382.165op/s 16955705.001op/s 16957614.443op/s 0.15% -1.357 9.938 0.06% 731.794op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.831µs 6.842µs ± 0.004µs 6.842µs ± 0.002µs 6.844µs 6.847µs 6.853µs 6.868µs 0.39% 1.325 9.004 0.06% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 145593138.679op/s 146156910.884op/s ± 86193.239op/s 146161113.836op/s ± 36810.154op/s 146195833.419op/s 146297661.004op/s 146362492.518op/s 146389105.446op/s 0.16% -1.309 8.900 0.06% 6094.782op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.270µs 4.290µs ± 0.002µs 4.290µs ± 0.001µs 4.291µs 4.294µs 4.296µs 4.298µs 0.19% -2.535 22.942 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 232648475.838op/s 233090305.195op/s ± 129987.408op/s 233096014.058op/s ± 60355.196op/s 233144996.985op/s 233246276.904op/s 233317312.550op/s 234170675.161op/s 0.46% 2.566 23.226 0.06% 9191.498op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 70.344µs 71.480µs ± 0.380µs 71.498µs ± 0.214µs 71.696µs 72.121µs 72.414µs 72.683µs 1.66% -0.003 0.603 0.53% 0.027µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13758282.117op/s 13990245.613op/s ± 74352.148op/s 13986317.932op/s ± 41822.656op/s 14033396.326op/s 14118006.487op/s 14170494.966op/s 14215762.580op/s 1.64% 0.044 0.607 0.53% 5257.491op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 65.448µs 66.414µs ± 0.329µs 66.427µs ± 0.239µs 66.662µs 66.943µs 67.084µs 67.196µs 1.16% -0.143 -0.281 0.49% 0.023µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 14881847.005op/s 15057449.673op/s ± 74656.794op/s 15054044.529op/s ± 54358.765op/s 15108373.061op/s 15178040.370op/s 15240379.832op/s 15279302.616op/s 1.50% 0.168 -0.260 0.49% 5279.033op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.277µs 4.290µs ± 0.002µs 4.291µs ± 0.001µs 4.292µs 4.294µs 4.296µs 4.297µs 0.14% -1.064 4.396 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 232743762.397op/s 233081728.944op/s ± 134154.340op/s 233072019.704op/s ± 56687.921op/s 233124233.274op/s 233319636.610op/s 233409131.168op/s 233823402.844op/s 0.32% 1.073 4.438 0.06% 9486.144op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.457µs 63.495µs ± 0.362µs 63.500µs ± 0.222µs 63.737µs 64.041µs 64.245µs 64.332µs 1.31% -0.420 0.361 0.57% 0.026µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15544479.109op/s 15749833.483op/s ± 89900.532op/s 15747980.040op/s ± 55016.138op/s 15800049.757op/s 15930739.496op/s 15989382.583op/s 16010888.210op/s 1.67% 0.458 0.405 0.57% 6356.928op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 58.977µs 59.060µs ± 0.033µs 59.062µs ± 0.018µs 59.080µs 59.110µs 59.137µs 59.169µs 0.18% -0.246 0.576 0.06% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16900800.750op/s 16932033.038op/s ± 9595.864op/s 16931259.088op/s ± 5280.547op/s 16936725.242op/s 16950750.865op/s 16954958.441op/s 16955679.549op/s 0.14% 0.250 0.575 0.06% 678.530op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.832µs 6.842µs ± 0.005µs 6.842µs ± 0.002µs 6.845µs 6.851µs 6.855µs 6.859µs 0.25% 0.516 1.240 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 145789049.826op/s 146149520.725op/s ± 99797.159op/s 146156701.079op/s ± 45799.506op/s 146193128.923op/s 146320663.338op/s 146363335.791op/s 146380091.426op/s 0.15% -0.510 1.231 0.07% 7056.725op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.290µs; 4.292µs] or [-0.016%; +0.016%] None None None
credit_card/is_card_number/ throughput [233015470.628op/s; 233090631.345op/s] or [-0.016%; +0.016%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [93.475µs; 93.617µs] or [-0.076%; +0.076%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10682323.993op/s; 10698168.707op/s] or [-0.074%; +0.074%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [87.941µs; 88.045µs] or [-0.059%; +0.059%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11358271.442op/s; 11371211.467op/s] or [-0.057%; +0.057%] None None None
credit_card/is_card_number/37828224631 execution_time [4.290µs; 4.291µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/37828224631 throughput [233023684.800op/s; 233108008.826op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/378282246310005 execution_time [85.502µs; 85.558µs] or [-0.033%; +0.033%] None None None
credit_card/is_card_number/378282246310005 throughput [11687995.092op/s; 11695638.827op/s] or [-0.033%; +0.033%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [59.055µs; 59.065µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16930609.217op/s; 16933477.795op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.841µs; 6.843µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 throughput [146144965.330op/s; 146168856.438op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.290µs; 4.291µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ throughput [233072290.190op/s; 233108320.199op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [71.428µs; 71.533µs] or [-0.074%; +0.074%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [13979941.121op/s; 14000550.106op/s] or [-0.074%; +0.074%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [66.368µs; 66.460µs] or [-0.069%; +0.069%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15047102.959op/s; 15067796.387op/s] or [-0.069%; +0.069%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.290µs; 4.291µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [233063136.442op/s; 233100321.445op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [63.445µs; 63.545µs] or [-0.079%; +0.079%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15737374.133op/s; 15762292.832op/s] or [-0.079%; +0.079%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [59.055µs; 59.064µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16930703.144op/s; 16933362.933op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.842µs; 6.843µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [146135689.799op/s; 146163351.651op/s] or [-0.009%; +0.009%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 44.87179% with 86 lines in your changes missing coverage. Please review.

Project coverage is 71.04%. Comparing base (5fd43ab) to head (c679a81).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #818      +/-   ##
==========================================
+ Coverage   71.01%   71.04%   +0.03%     
==========================================
  Files         313      315       +2     
  Lines       45972    45972              
==========================================
+ Hits        32645    32659      +14     
+ Misses      13327    13313      -14
Components Coverage Δ
crashtracker 38.52% <44.87%> (ø)
crashtracker-ffi 5.71% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.71% <ø> (ø)
data-pipeline-ffi 90.08% <ø> (ø)
ddcommon 82.08% <ø> (ø)
ddcommon-ffi 65.84% <ø> (ø)
ddtelemetry 59.51% <ø> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 89.59% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.69% <ø> (ø)
profiling 84.29% <ø> (ø)
profiling-ffi 77.55% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.91% <ø> (ø)
sidecar-ffi 3.98% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 93.60% <ø> (ø)
trace-mini-agent 72.48% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.79% <ø> (ø)

@danielsn danielsn requested a review from a team as a code owner January 10, 2025 21:12
@danielsn danielsn force-pushed the dsn/crashtracker-split-receiver branch from 2c6f6d1 to 527eae3 Compare January 10, 2025 21:26
@danielsn danielsn merged commit adc183e into main Jan 14, 2025
31 checks passed
@danielsn danielsn deleted the dsn/crashtracker-split-receiver branch January 14, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanchda sanchda sanchda approved these changes

Assignees
No one assigned
Labels
crashtracker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielsn @codecov-commenter @sanchda